William Lucas
William Lucas
The latest commit aligns photon objects in the photon pooling pipeline with their positions in the original pipeline.
Almost there, but blocked by GalSim-developers/GalSim#1284.
This is finally open for review -- all comments welcome.
The latest set of commits should address most of the comments above. I'll respond to those individually. A couple do still need to be looked at.
Not just yet -- I have a couple more commits on the way with fixes and tests for the batching. I'll push these later today or tomorrow, and then I...
I think this is ready for re-review now, though CI is failing with an error in `test_stamp_bandpass_airmass` from numpy coming through GalSim. I saw the same error a couple of...
I think there is actually one more commit incoming. I've realised that in edge cases where nominally bright photon objects' `phot_flux` falls below `nbatch`, we can end up with batches...
OK, that should be it -- code open for review!
Assuming tests pass, that should be everything above. I've included changes to `RubinOptics` to use `stamp_center` rather than `image_pos`, changing the tests to fit, but let me know if you...
I've just created PR #484 which corrects the photon op tests to be self-consistent. There were actually a couple of inconsistencies in the tests here too, but working through them...