Stefan Gränitz

Results 54 comments of Stefan Gränitz

This aims to workaround the bug tracked in https://github.com/gnustep/libobjc2/issues/222

The bot failed before running tests in build step: ``` [112/229] Building C object Test\CMakeFiles\PropertyIntrospectionTest2_arc_optimised.dir\PropertyIntrospectionTest2_arc.m.obj ``` https://dev.azure.com/gnustep/libobjc2/_build/results?buildId=507&view=logs&j=d0cab528-cccd-5180-b7d9-4b8b4ac0b9c3&t=f671b46d-dd84-5da8-a465-97dc8caf7fa9&l=618

Hi David, thanks for your quick reply. Right, that seems to be the issue. In fact `PropertyIntrospectionTest2_arc` is the only test that uses `stdatomic.h` directly! I dropped the include locally...

[The remaining tests passed](https://dev.azure.com/gnustep/e3d06b1c-9d1f-4aef-966e-70c0f260f8e2/_apis/build/builds/509/logs/151): ``` 2022-04-28T12:08:53.9584777Z 85/92 Test #87: ObjCXXEHInterop .......................... Passed 0.05 sec 2022-04-28T12:08:53.9594245Z Start 91: ObjCXXEHInterop_arc 2022-04-28T12:08:53.9600823Z 86/92 Test #89: ObjCXXEHInteropTwice ..................... Passed 0.04 sec 2022-04-28T12:08:53.9608378Z Start 92:...

> Can you guard the `#include` and the use of `atomic_bool` with a Windows-specific macro so that we can skip the part of the test but keep running the rest?...

Hi David, sorry for the late follow-up. Actually, this PR is outdated. Instead of using the workaround, we should enable this test for Clang versions 15+. Let me put together...

I was about to [propose a change that enabled the test](https://github.com/weliveindetail/libobjc2/commit/a24f952c4387159e182553c57cf8eac3de9c0765) on Windows when using Clang 15+ as the host compiler, when I realized that it still crashes! The nested...

Review for a fix/workaround candidate: https://reviews.llvm.org/D134866

I was working on a [PR to enable the ObjCXXEHInterop_arc tests on Windows in Clang 15+](https://github.com/weliveindetail/libobjc2/commit/a24f952c4387159e182553c57cf8eac3de9c0765) when I realized that there is a second side-effect that we didn't fix with...

If this really fails on Linux then it's a bug. I am not sure about the state of ORC/JITLink on FreeBSD, but I'd guess that it should work, because I...