Wei Jian Gan

Results 19 comments of Wei Jian Gan

> Was able to fix the issue by removing the line `import django_prometheus.models` and `bases=(django_prometheus.models.Mixin, models.Model),` from all `migrations.CreateModel`. > Afterwards I was able to successfully run the migrations. >...

I wish to report the same for `microsoft-typescript-language-server`

@thomasf that's more of a workaround rather than a proper solution isn't it

> My screen does not look like yours ![image](https://private-user-images.githubusercontent.com/32853531/371217369-3d6d8a37-5a97-4918-98c8-bc1fff43777f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mjg1MTMxMTksIm5iZiI6MTcyODUxMjgxOSwicGF0aCI6Ii8zMjg1MzUzMS8zNzEyMTczNjktM2Q2ZDhhMzctNWE5Ny00OTE4LTk4YzgtYmMxZmZmNDM3NzdmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEwMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMDA5VDIyMjY1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVkZTIzNjQyZjk3MGEzNzAxMzcyNzdkNWRhYzI0ZDQzMmQ1NmVmOWEyOTM5NTQ2MTY2YzEyNTJlNmFiY2RlNzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.FSlbUjvrlkPArjTtaNdCyCgV5pKWj4_SPQ_QJLPU6Yg) browsers have a tendency to cache the style.css file make sure you load the right version. I just rebased it and...

> Why are we adding the logo.svg back here? > > Anyway, looks like it's almost there! I cloned it to remove the extra spacing around the svg. We can...

@Firstyear added unix password use toast for reauth message I guess if you don't like the toast change you can just revert the commit. Sorry I don't have time to...

> Please don't use toasts for the reauth message (or anything that - they rely on javascript, are temporary and are easily missed. The bootstrap alerts element is static and...

@Firstyear maybe I should rename the title of the PR to make the changed scope more apparent rather than trying to combine a discussion starter and a PR :D

I have a few non-blocking nitpicks on CSS but I think it's really cool you're able to get it done so quickly and functionality-wise it's complete.