code comments

Results 478 comments of


                                            code

json log with sort_properties prints decimals for all numbers

All numbers is float now in the log formatter (and in the Protobuf::Value) The key problem is the Nlohmann json lib. In the previous implemention of json formatter, if sort...

json log with sort_properties prints decimals for all numbers

> Oh this might be solved by https://github.com/envoyproxy/envoy/pull/35545 -- @wbpcode WDYT? > Yeah, I think so.

json log with sort_properties prints decimals for all numbers

Remember you still need to set a runtime flag for now. Our unit tests tell me it should be fixed.

json log with sort_properties prints decimals for all numbers

should be closed by #36629

tracing: expose trace info in dynamic metadata

Thanks for the contribution. There are two main changes here. One adds `getSpanId` method to the tracer. One change to the contrib go. Could you split them to two independent...

tracing: expose trace info in dynamic metadata

LGTM. Thanks.

tracing: expose trace info in dynamic metadata

> Funny, 2 hours ago #33909 was merged, which also implemented `getSpanId`. > > @wbpcode would you be okay with me altering this PR yet again to target the Go...

OpenTelemetry access logger support extension formatters

>. I don't have a strong opinion here, but if in the file access logger you need to specify the formatters explicitly, then it makes sense in OTel as well...

Connection attribute connection.transport_failure_reason doesn't work as expected

cc @kyessenov

generic proxy: enhance match input data to support more attributes

friendly ping for a blind approve for this contrib only change @jmarantz (sorry for the frequent ping, because you are on-calling this week 🌷