wattroll

Results 19 comments of wattroll

Yeah would totally work as a starter. I've checked http://www.languageicon.org/ and the license is clearly stated, so we can modify and use it without strong rules on how to provide...

> they are too complex to be used in an UI That makes sense. Thanks for taking time to check it. > I think ф is preferable to Ё since...

Very well, thanks for feedback. Yep, I'll add examples and jsdoc for them after cleaning up the code. Also tests.

@wolfgangwalther I see the concern regarding the schema isolation. As you say, it can be seen from several perspectives. On one side sending the constraint name seems like relying on...

> Right now there is no way to call Body#formData on arbitrary user input without potentially causing an OOM How about sinking a `clone()` of the request prior to calling...

@matthieusieben > your approach is great but it does load everything in memory Good point. Everything in this case would be at most `maxByteLength` bytes that will get buffered into...

### Expected behavior I think that `persister.load()` shouldn't throw when `getPersisted` returns `undefined` since returning `undefined` is permitted by a type and seems to me like a reasonable result of...

I've also been thinking that since it's common for persisters to return result of `JSON.parse` without putting it through any validation, it would make sense to have tests that ensure...

> I can't get it to throw, per se... it appears as an ignored error: You are totally right. I had a better look and confirmed that the actual throw...

> Tests in https://github.com/tinyplex/tinybase/commit/fbafcf19df29af69d73e1cf2a9eac407fc962010 and changes to the way things are handled in https://github.com/tinyplex/tinybase/commit/9f4d9eb211959acfa0787600dc197bbd577598df - both released in v5.0.5. Looks great. Thanks! I believe on developer-end it's a lot nicer...