wasimabbas-arm
wasimabbas-arm
> Does `clang-format` write DOS line endings? I noticed the `dos2unix` at the end of the script. No this is a copy past error. I prefer my line endings in...
> Please don't do this in a open source library `UseTab: ForIndentation` So this is indeed a holy war I don't wanna start. Just reminds me of https://www.emacswiki.org/emacs/SmartTabs and the...
@MarkCallow for your review.
> Before we proceed any further please create a short document describing your plans: @MarkCallow https://docs.google.com/document/d/1bIsYcornoFjVVLuBGNX6j0cIooYJAwXBPngl0iNmOu4/edit?usp=sharing is a document I created with my proposal. Please have a look. Haven't worked...
Looks like there has been a lot of changes since I made this PR. Will take me a while to rebase and make the required edits. On it.
For the failing tests, I have tried to fix those in the CTS but looks like @MarkCallow you have had a go at those already especially for `deflate`. After pulling...
> @wasimabbas-arm are the tests working for you locally? Did you have to modify any of them? @MarkCallow No they don't. ``` The following tests FAILED: 611 - ktxToolsTest.create.compare (Failed)...
> git submodule update tests/cts will checkout in tests/cts the commit that is referenced in your KTX-Software workarea. When you rebased to current main that commit will be the one...
Ah here we go. The script has ``` if [ "$FEATURE_TOOLS_CTS" = "ON" ]; then git submodule update --init --recursive tests/cts fi ``` So it is putting you back on...
> You can workaround this by committing the new reference (`git commit tests/cts`) before you run the script. Thats what I have done now. But at least the mystery is...