William Muir

Results 24 comments of William Muir

It looks like you are attempting to install v2.6.0 bindings. If so, you'll need to follow the instructions in #38. Otherwise, please provide additional information (OS, Go version). Have you...

How are you invoking `go build` (i.e., what command(s) are run within the Makefile's build rule)? Are you attempting to cross-compile by setting `GOARCH` to `amd64`? As you state, your...

This error is due to your build and installation of libtensorflow. There is an open issue for building libtensorflow on M1 at tensorflow/tensorflow/issues/52160 and I see that you have also...

> If I copy the x86 files into /usr/local/lib I got a different error Let's start here: what are you trying to do?

The binaries that you downloaded are for x86_64, which is a different architecture than that of your system. Presumably, when you built libtensorflow from source you targeted your system's architecture...

> just a drive-by comment: > could you run the benchmarks before/after the proposed optimization a couple of times (say 10-20) and show the result of `benchstat`? > with the...

Most recent commit addresses review comments, except for the switch to sub-benchmarks. I'll need to push a second commit to update the benchmarks. I attempted some further simplification of the...

| name | old time/op | new time/op | delta | | :------------------ | ----------: | ----------: | -------------------------: | | Format/10/General | 52.6µs ±17% | 68.8µs ±18% | +30.74%...