walkingeyerobot
walkingeyerobot
Fixes #5902
> Just for fun I wrote a very simple C program that generates `src/passes/WasmIntrinsics.cpp` directly from `src/passes/wasm-intrinsics.wat`. No need for a template file, and this also eliminates the need to...
> Recommendation: follow Bazel best practices; in particular, avoid toplevel build targets like `bazel build :foo`. Also prefer one BUILD.bazel file per source directory. Better to avoid having file paths...
> @walkingeyerobot Although I agree that more granular targets are better, I think we should try to keep this PR minimal and follow what we had in google3. I think...
Hey, thanks for taking a shot at this! I'm happy to take a look. What are you hoping to do with binaryen after you've got it building in bazel? Consume...
I think you're on the right track wanting to abstract that out, and you're right that a shell script isn't portable enough. A little C program would be fine, but...
Apologies for the delay. Turns out there is yet more interest in making this happen, so I think this is definitely a good idea to add. A colleague of mine...
There's a fair bit of talk about "google3" in the PR and I want to give some context to @mobileink so they can better follow and participate in the conversation....
Appreciate the update, even if it's not the update I was hoping for.
I'll also note that some of the infrastructure here will be useful for adding wasm64 support per #1464