Walid Boudebouda
Walid Boudebouda
Updated the doc to mention that -p fails when vcl_path is read only
> Wouldn't this deserve a separate lock? No strong opinion on this, but does it really deserve a separate lock ?
> better idea found during bugwash: do not take the lock if the tag is filtered, but keep it on the session lock Added in [42d961a](https://github.com/varnishcache/varnish-cache/pull/4095/commits/42d961ac4e677316dd602a22e382322bf4b24d51)
Rebased and squashed, merging after CI completes.
> Not sure how much attention it got, but after this was merged we had a complaint from Coverity Scan: > > ``` > *** CID 1641631: (USE_AFTER_FREE) > /bin/varnishd/cache/cache_vcl.c:...
> In order to make the VTCP_Connect to fail, the backend needs to either not be in the LISTEN state or we need to initiate the handshake with a peer...
> > > In order to make the VTCP_Connect to fail, the backend needs to either not be in the LISTEN state or we need to initiate the handshake with...
> what about this? > > > Maybe we need a facility in varnishtest which listens on a socket, but just never accepts some something similar? This wouldn't work with...
https://github.com/varnishcache/varnish-cache/pull/4222
@DemiMarie Would you be able to submit a PR with your suggested fix ?