varnish-cache icon indicating copy to clipboard operation
varnish-cache copied to clipboard
verified publisher icon varnishcache

Consistent locking when logging to H2 session vsl

Open walid-git opened this issue 1 year ago • 1 comments

Currently, some of the logging to the H2 session vsl is done withouth holding the session lock, even when multiple streams are active. This PR is an attempt to make things more consistent in that regard.

walid-git avatar Apr 23 '24 12:04 walid-git

Wouldn't this deserve a separate lock?

nigoroll avatar May 24 '24 12:05 nigoroll

Wouldn't this deserve a separate lock?

No strong opinion on this, but does it really deserve a separate lock ?

walid-git avatar Jul 08 '24 14:07 walid-git

better idea found during bugwash: do not take the lock if the tag is filtered, but keep it on the session lock

nigoroll avatar Jul 15 '24 13:07 nigoroll

better idea found during bugwash: do not take the lock if the tag is filtered, but keep it on the session lock

Added in 42d961a

walid-git avatar Jul 18 '24 10:07 walid-git

OK with me.

bsdphk avatar Aug 05 '24 14:08 bsdphk

Rebased and squashed, merging after CI completes.

walid-git avatar Aug 06 '24 07:08 walid-git