Victor Willyams

Results 9 comments of Victor Willyams

I noticed that this previously didn't resolve https://github.com/daniel-nagy/md-data-table/issues/422 so I went back and resolved all the issues there, along with a few bonus fixes and a new button added to...

FYI: example functionality in https://codepen.io/vwillyams/pen/KvdYjZ (using very ugly theme as the alternate, to show off how it works)

@pkcat please provide a replication, I was unable to replicate this - see https://codepen.io/vwillyams/pen/Nvjyrz for a quickly hacked together example of this working

@pkcat this scenario is now fixed (was bypassing the normal theme inheritance)

Created a PR which should resolve this (now that angular-material has added the `$mdThemingProvider.registerStyles` method): https://github.com/daniel-nagy/md-data-table/pull/607

Created a PR to resolve this: https://github.com/daniel-nagy/md-data-table/pull/607

Looks like sass-loader fixed the underlying issue (https://github.com/webpack-contrib/sass-loader/issues/774) but SassSvgInlinerFactory still fails with exactly the same problem - anyone have any insight?

FYI I will hopefully find time to have this ready for merge in the next 2-3 days. I'm going to get this working with RSCs and I also want to...

FYI I'm currently iterating on the test coverage and making sure this works in all cases. I didn't entirely expect the amount of complexity that would go into this feature!...