Valeriy V. Vorotyntsev

Results 9 comments of Valeriy V. Vorotyntsev

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option

> The value should work with data type `float64`, but at first the value is smaller so inferred as an `int64`, lately the value has become bigger and bigger, and...

I see. [It looks like](https://stackoverflow.com/questions/13502398/json-integers-limit-on-size#comment80159722_13502497) JSON integers are limited to `[-(2**53)+1, (2**53)-1]`.

> This might be intentional for docs.rs example? Oh. I wasn't aware of this peculiarity of docs.rs. Shall we close the PR then?

@fwilliamhe Thanks for the feedback. 1. Please help me understand what exactly is not right. i. Is it [JA4 specification](https://github.com/FoxIO-LLC/ja4/blob/f6a1aaa366c964502d0beef17d48e6c7b1aba20d/technical_details/JA4.md)? ii. [Python application](https://github.com/FoxIO-LLC/ja4/tree/f6a1aaa366c964502d0beef17d48e6c7b1aba20d/python)? iii. [Wireshark plugin](https://github.com/FoxIO-LLC/ja4/tree/f6a1aaa366c964502d0beef17d48e6c7b1aba20d/wireshark)? iv. [Rust application](https://github.com/FoxIO-LLC/ja4/tree/f6a1aaa366c964502d0beef17d48e6c7b1aba20d/rust/ja4)? 2....

See also [winnow = toml_edit + combine + nom](https://epage.github.io/blog/2023/02/winnow-toml-edit-combine-nom/). `chumsky` didn't meet their performance and ergonomics criteria. (It still may be a good choice for `promql-parser` though.)

@Squiblydoo Initially the Rust apps (`ja4` and `ja4x`) were developed in a closed repository. We did build unsigned macOS binaries there, but that drained our CI/CD minutes [quickly](https://docs.github.com/en/billing/managing-billing-for-your-products/managing-billing-for-github-actions/about-billing-for-github-actions#minute-multipliers) and I...

The problem is reproducible with this capture file: [badcurveball-alpn-not-isalnum.pcap.gz](https://github.com/user-attachments/files/18480592/badcurveball-alpn-not-isalnum.pcap.gz) ```diff ❯ diff -u

## Analysis `ja4` Rust app uses [`rtshark`](https://lib.rs/crates/rtshark) v2.6.0. https://github.com/FoxIO-LLC/ja4/blob/aca2a0f6032566abf6732afffc5d6fbd52a82061/rust/ja4/Cargo.toml#L26 [`rtshark::Metadata`](https://docs.rs/rtshark/2.6.0/rtshark/struct.Metadata.html) in that version of the library does not expose the original (raw) bytes: ``` ❯ cargo run -q --manifest-path rust/Cargo.toml...