Vincent Thiery

Results 17 comments of Vincent Thiery

Hi! Unfortunately this client is not thread-safe. Nothing prevents a thread to alter the internal udp sender while another one is already sending metrics.

@hh23485 I suppose that, as long as you don't explicitly reconfigure or destroy the client while using it, it will be ok. In the context of a web project, one...

> But to be more clear, do you mean, it's safe to call the singleton client's `increment` or `timing` from multi threads? or I need to do my actions to...

@hh23485 have you had any issue related thread-safety? otherwise, I'll close this issue.

@jakila thanks for pointing that out. I'll re-open this issue and hopefully get some time to investigate it soon

Another problem that is linked is that `time.Sleep(backoffTime)` will be called even when the retries are exhausted, which can lead to quite a waste of time for the caller. If...

Thanks @martin-sucha for the investigation! We're definitely going to fix this double query issue on our side...

> Thanks for the contribution! I'm happy to add asdf support, but I'd like to have the plugin repo as part of the same repo. Is there a way to...

> Transfering to asdf-community would be optimal, thank you Let me proceed with the transfer then and I will update this PR accordingly.

Hi @christophetd, I'm still waiting on the asdf-community to initiate the transfer https://github.com/asdf-community/infrastructure/pull/149