Vipul Rahane

Results 19 comments of Vipul Rahane

Thank you for the quick review @thiagomacieira , I have rebased and resolved all conflicts. I would like to understand more about how you would like to split this PR...

Ah, I see what you mean now. I have created a consolidated PR for now. I will remove any bug fixes from this and put them in separate PRs. Thank...

@thiagomacieira Are you suggesting a change to the API that the PR adds. I have rebased and resolved the conflicts that were introduced by the most recent merges.

Thank you for the reply. The code from cbor.h has been moved to src/cbor_buf_writer.c. The constants & enums have been moved to cbor_defs.h. Code has not been removed. There are...

There were compilation errors with cbor.h being included in src/cbor_buf_writer.c and src/cborparser.c. Hence, the new headers which separate out cbor constants and enums from inline apis. I do not have...

There was some confusion, because the hash you had provided was from intel/tinycbor/dev and the URL pointed to your dev branch of your fork of tinycbor. Hence, the confusion. I...

I have rebased and resolved conflicts, I did the following: In my earlier version of the PR I had an `added` and `container_size`(used only if it was a container) fields...

@thiagomacieira Can you please restart the travis-ci build. It seems it has got stuck in some intermittent state.

So, this can be solved by specifying `pkg.cflags:` for the respective BSP. apps, BSPs, targets and compiler packages when provided with `pkg.cflags` get applied to the entire build. cc: @ccollins476ad...

So, I think we can resolve this issue.