Volker Brendel

[Issue] pileup "feature"

4

The pileup.c code implicitly relies on alphabetical ordering of the SQ entries in the input sam/bam header, at least for the tsv display. The data columns in the tsv file...

Copy/paste errors in the code which leads to wrong output in the tsv file; the corrected code is shown first, versus the current code in your repository. pileup.c SHOULD BE...

Minor edits: # Download precomiplied binaries wget -O- https://github.com/attractivechaos/k8/releases/download/1.0/k8-1.0.tar.bz2 | tar -jxf - should be # Download precompiled binaries wget -O- https://github.com/attractivechaos/k8/releases/download/v1.0/k8-1.0.tar.bz2 | tar -jxf -

src/fasta_formatter/fasta_formatter.cpp

3

Line 105: usage(); should be followed by "exit();" Otherwise, compilation fails on Ubuntu 18.04 with message: fasta_formatter.cpp:105:9: error: this statement may fall through [-Werror=implicit-fallthrough=] usage(); ~~~~~^~ fasta_formatter.cpp:107:3: note: here case...