vooft

Issue in Smile shared string values due to avoiding 0xFE and 0xFF

5

Hello! I'm working on my own smile serializer/deserializer and, I think I found an issue in the Jackson implementation that does not match the specification. https://github.com/FasterXML/jackson-dataformats-binary/blob/1e4017a99143f0c6eb1ce86af4e144a2eebd1c0c/smile/src/main/java/com/fasterxml/jackson/dataformat/smile/SmileGenerator.java#L2732-L2743 According to the spec,...

Clarification of the shared strings algorithm

1

Re https://github.com/FasterXML/jackson-dataformats-binary/issues/495 Some indexes must be skipped during the shared string handling, however the same values may be shared later. This logic must be replicated on both serializer and deserializer...