Dmitry Maganov

Results 96 comments of Dmitry Maganov

Haven't this ec69d883b014738bbc7e0a9acbd10349992e88b9 recent commit disabled stack checks for apple devices already (i am on mac)? (And strange thing for me is that this error appears only in worker thread,...

On my machine - no. Steps i used to reproduce: `git clone --depth=1 --branch=3.2 [email protected]:godotengine/godot.git` `git clone [email protected]:Geequlim/ECMAScript.git` (in `godot/modules`) `python3 $(which scons) platform=osx --jobs=$(sysctl -n hw.logicalcpu)` (in `godot`) `git...

`res.concat('a')` does not mutates original string. It returns new one (just like concat for arrays). So it should be `res = res.concat('a')`.

Yeah, but why it was done only for `return_type`?.. Anyway, if new info will be complete in that regard then i have no problem with closure of this issue.

Last one of those closings. I will rebase it when asked. Assuming that the proposition is accepted.

As hashlink can be embedded it is worth looking into WASM even if performance is the same as vanilla js.

I don't think it is necroposting as it is one of few open issues here. And as I understand until your PR is merged it is still valid one. After...

I'm ok with closing, since the hooks functionality was moved to separate repository and it should be added there, not here. But no, just checking `params.provider` is not an option...