Vladimir Kozlov
Vladimir Kozlov
> Is there interest in getting rid of RTM locking, or should I close this PR as won't-fix at this point? Close PR.
> > Initial review of few `code/` files. Will do more later. > > I am not comfortable with name `unloading` for this process because historically, for me, it is...
> > What about adjust_scalar_replaceable_state() code mark allocation as non-SR if they are merged? > > I didn't get this part. Can you please clarify? My bad. After looking more...
Hi @JohnTortugo Yes, I think you can lift restriction for all inputs have the same class. I looked more and you correctly set RAM's type to original Phi's type -...
Allocations in `testPollutedPolymorphic()` are removed because both classes have the same `Shape` class which have all fields. Would be interesting if `l` field is declared only in both subclasses.
@JohnTortugo Yes, you would need to construct Phi when you replace RAM with `SafePointScalarObjectNode`. Hmm, may be you would need to construct Phi in other cases too (getClass intrinsic). Add...
@JohnTortugo Good news is that I ran from tier1 to tier4 and with `ReduceAllocationMerges` enabled and I did not get new failures except in your new test `compiler/c2/irTests/scalarReplacement/AllocationMergesTests.java` when it...
/reviewers 2
We need others to look on this too at this stage.
And I will submit performance runs.