Vladimir Morozov

Results 90 comments of Vladimir Morozov

As we discussed today in Node-API meeting, one of the changes in this PR is the grouping of parameters inside of a new `node_api_native_data` struct. This struct should allow us...

This PR was discussed today in the Node-API meeting and the suggestion was to reuse the existing `napi_ref` instead of adding the new `napi_persistent` type. I am going to add...

@mhdawson, @legendecas, @NickNaso, per our discussion today at the Node-API meeting, I had updated the PR description and added a note to the doc that `node_api_create_reference` is targeting to replace...

> I believe it would be beneficial to strive to extend the maximum capability of existing APIs and try not to introduce new APIs for differences that are hard for...

> Some thoughts on naming. Maybe these would work? > > * node_api_reftype_any > * node_api_reftype_object @mhdawson, I have changed the names.

We have two "virtual interns" @avmoroz and @alexmoroz15 working this summer on implementing the ReactNative for Windows AppCenter modules for analytics and crashes. Currently they work on implementing the Demo...

My understanding of the issue is that NAN uses the [V8 ObjectTemplate](https://v8.github.io/api/head/classv8_1_1ObjectTemplate.html) that uses Proxy-like methods for Object's getters and setters to access all object properties. In Node-API we use...

We used a very similar approach before to implement [JSI on top of Node-API](https://github.com/microsoft/react-native-windows/blob/9d5106d129ad235b40de45400b74c2fb92a82372/vnext/Microsoft.ReactNative.Cxx/JSI/NodeApiJsiRuntime.cpp#L1802). The plan is to add unit tests to depo the approach with the plain Node-API and...

I had started to work on the unit test. So far, it works for a very simple object. I am going to continue to improve the code to cover more...

@ilitosh, the PR is missing the change file. Please run "yarn change" to create it.