Vincent Marta
Vincent Marta
@bendvc Follow-up to our earlier conversation on Slack: yup, there is a bug that can be seen by loading the retail-react-app-template, specifically with how `extraGetPropsArgs` is being shared across components....
@kevinxh in the test project, do you get an **error when logging in as a registered user**? For me, I saw an error in that scenario. And I continued seeing...
If you're curious why the CI tests are failing, it's because we need to import `regenerator-runtime` package when testing _async_ functions. I saw it in my branch, and I fixed...
v1.6 was never released, and we're not going to.
> Should we be running the translation scripts (i.e. extract-default-translations) every time a localisation is added/modified? Not only that extract script, but also the compile one. Because retail-react-app would try...
About the inconsistency you found in the test setup, the `DEFAULT_LOCALE`s should match. At some point, it was changed from en-GB to en-US. But the tests were probably not updated...
@LucasReyre I was able to reproduce what you saw. Thanks for reporting this bug.
@alexvuong I think we need to reconsider how the price is displayed for Product Set. It looks like we currently compare the min and max prices of a particular price...
Thanks @clavery for reporting this bug.
@alexvuong Are the product categories inside the nav menu part of the ticket's scope? If yes, I wonder why the categories are no longer lazy loaded.. On desktop, the categories...