Vladimir Moskva

Results 72 comments of Vladimir Moskva

The reason the warning doesn't exist is that buildifier doesn't know which global variables are available in which types of files. Is there an up-to-date list of existing globals for...

This looks reasonable to me. Two things: * With the (current) command line interface warnings won't work unless you provide `--lint=warn` (to show the warnings) or `--lint=fix` (to fix if...

@anandwana001 do you want to enable all the warnings, even those that are disabled by default, except one?

It does make sense to not move comments in these examples, however it's easy to imagine one where a comment is attached to a load statement and should be moved...

Will it be enough to allow macros to have no `name` argument if its name ends with `_test_suite`?

Or is it better to ignore calls to `native.test_suite()`? E.g. if a function calls just this rule and no other rules (maybe transitively via other macros), it's ok that it...

> The check could also be avoided by possibly wrapping the native.test_suite call inside the macro in its own macro That shouldn't work, buildifier can resolve transitive calls to rules...

In this particular case ignoring `native.test_suite()` will work, because: 1. The test rules mentioned above are rules because they call `analysistest.make()` which is defined in another repository, and cross-repository analyisis...

If you want to build a binary and then run it independently, use `bazel build` instead of `bazel run`, the latter creates a special bash script that's meant to be...

Perhaps we can try to change the current behavior and I'll try to estimate how many existing users are broken by that, at least internally. Then we can decide if...