Victor Kobinski

Results 14 comments of Victor Kobinski

This issue was resolved at https://github.com/seanmonstar/httparse/pull/147

@lpil What should I do with the tests that use a single case pattern match? Change them?

> Probably, yes. Also, you'll want to add tests for this new warning. And in the issue I mentioned adding a code action to fix this warning. Do you think...

I am implementing the changes you both suggested!

@GearsDatapacks can you suggest any example of a single case simplification where the pattern is not a constructor?

I was able to implement the code action for the constructor case! I'm going to make the code action work for other cases too.

I'm going to work on this issue.

> I think that's a great idea, we could also try and be more specific with the error message, for example if one writes `a.b` and module `a` actually has...

This change needs to be made in this [file](https://github.com/gleam-lang/gleam/blob/5406c800454a608e61d447ccd5799f10ae0e8149/compiler-core/src/parse/error.rs#L198). I think we’ll need to change the structure of this function to handle just this case. Maybe this case can be...