Vivek Khatri

Hey @anonrig I want to take a go at this. Modifying the above regex to the below one should fix this, but can there be a more generic regex? A...

@lzchen I have added the field to the api (the place you pointed to in the code)

> @vivek378521 could you please fix lint errors? There was an import statement linting issue, I fixed that, ran `tox -e lint` 10/10. :')

@lzchen You mean here: https://github.com/open-telemetry/opentelemetry-python/blob/e44bffe533cbe74659416dc1282e7dd20a35d15e/opentelemetry-api/src/opentelemetry/metrics/_internal/__init__.py#L144C9-L144C42 and here: https://github.com/open-telemetry/opentelemetry-python/blob/e44bffe533cbe74659416dc1282e7dd20a35d15e/opentelemetry-api/src/opentelemetry/metrics/_internal/__init__.py#L160 ?

So just these changes, right? ``` def get_meter( self, name: str, version: Optional[str] = None, schema_url: Optional[str] = None, attributes: Optional[Attributes] = None, # here? ) -> "Meter": """Returns a...

yay, all checks passed! 🥳

So we replace the line with something similar in function and remove the Parser::new dependency?

Please correct me if I am wrong, but this is what I understand about this issue. There is a `LoggingHandler` class and in the init method there is a `get_logger`...

So we can give the user the option to add InstrumentationScope object (optional) when they instantiate the LoggingHandler. I can raise a PR for this in some time if the...

Thanks for the help @emdneto! So I have made the changes and added a test that confirms that we are able to set the instrumentation_scope values, but I now need...