Pete

[draft] chore(react): Explore upgrade to react 18

9

⚠️ _note_: **not** ready for merge. ### TODO _Redwood deps we need to have React 18 support before upgrading_ (links to open Issue(s) if applicable) - [ ] Needs -...

- [ ] Allow for better independent deployment of Storybook artifacts #5534 - [ ] Support merging `webpackFinal` / `managerWebpack` #5957 - [ ] Support `async` fields in Storybook configs...

Make `"eslint.packageManager": "pnpm"` in `.vscode/settings.json`?

1

https://github.com/wtchnm/Vitamin/blob/0d6270b6fc107e12c25a39a9f8e925f56a147631/.vscode/settings.json#L13 is there a benefit to making this be `pnpm`? afaik, it being set to `yarn` is probably benign; but just wanted to call it out in case it helps....

`test-storybook` is displaying `PASS` when the story has a TypeError

2

### Describe the bug `test-storybook` is displaying `PASS` when the story has a TypeError(s). ### Steps to reproduce the behavior 1. create a story that has type errors, e.g. `BlogPost.stories.tsx`...

chore(react): use `updater` callback function

2

callback takes the previous state as the first argument. > setState() does not always immediately update the component. It may batch or defer the update until later. This makes reading...

`AuthProvider` can cause "Warning: Can't perform a React state update on an unmounted component."

7

seems to stem from: https://github.com/redwoodjs/redwood/blob/main/packages/auth/src/AuthProvider.tsx#L263-L270 not clear on if/how we might leverage `componentWillUnmount` to cancel the promise chain. ``` @redwoodjs/auth: FAIL src/__tests__/AuthProvider.test.tsx (10.582 s) @redwoodjs/auth: ● Console @redwoodjs/auth: console.error @redwoodjs/auth:...

Some breaking changes were introduced with the [new version](https://github.com/prettier/prettier/releases/tag/3.0.0) of prettier. It looks like at the very least this like will need updating: * (`const PRETTIER_PATH = require.resolve('prettier/bin-prettier');`) https://github.com/nrwl/nx/blob/64765eb313d33c93bd4db35d86b21ecb43fa5757/packages/nx/src/command-line/format/format.ts#L26 due...

### Summary _⚠️ - notes from investigating codebase ESM conversion effort, not yet summarized - ⚠️_ #### Resources - https://gist.github.com/Jaid/164668c0151ae09d2bc81be78a203dd5 - https://blog.isquaredsoftware.com/2023/08/esm-modernization-lessons/ - https://github.com/arethetypeswrong/arethetypeswrong.github.io/tree/main/packages/cli ###### Related PRs - https://github.com/redwoodjs/redwood/pull/9667 -...

Experiment into dual package publishing.

Came up while upgrading [jest-styled-components](https://togithub.com/styled-components/jest-styled-components) | [`7.0.8` -> `7.1.1`](https://renovatebot.com/diffs/npm/jest-styled-components/7.0.8/7.1.1) possibly related to #355 ( and in turn #419 ). It seems as though what once were separate lines, became one....