Virl comments

Results 47 comments of


                                            Virl

Editor edit(String key, long expectedSequenceNumber) should throw ConcurrentModificationException

It should NOT throw ANYTHING, it should successfully return another Editor and allow concurrent modification of cache.

Concurrent edit experience is cumbersome

@chrisbanes uh what an ugly code. Why does this lib not supporting this from the box like TMCache? :(

Weak reference to the subscriber

Please implement this.

Add completion handler compatible with UIActivityViewControllerCompletionHandler and re-using iOS6 compatible activities name.

Please integrate that.

Method for both removing and adding annotations

Yes, it will make more universal API, but for now I think it is overengineering. Let's accept my pull request and if someone will need begin/end updates then convert api...

Method for both removing and adding annotations

Hi. Will you accept this PR?

AbstractEvolutionEngine Design Coupling Issue

Also see #29

Batch evaluation

Basically I need something like this: https://github.com/drone-ah/watchmaker/commit/15f850adebe6aec84459cdd1b79e1ff0dd06031b

Memory leak!!

Please fix this bug.

Memory leak!!

Test is wrong. Memory leak is present when you're iterating over result set returned by find(). Also me personally encountered it while using DAO. Create BasicDAO object and call find()...