Vince Prignano

Results 463 comments of Vince Prignano

Thank you all for the context. It seems like the best path forward is definitely to have a separate extension that can work together with vscode-go. Initially, I opted to...

@BenTheElder Can you try with `GO111MODULE="on" GOFLAGS="-mod=vendor" ` as well? We're about to hit this in cluster-api soon :)

Oops, sorry I missed the other comment above yours which suggested the same. I wonder how this will perform with the latest build of code-generator, which should be using tools/packages...

@nikhita I think I might have talked too soon :smile:. We should definitely get this on the roadmap, maybe with a feature flag and documentation to opt in?

From a quick glance, the current changes make sense to me, although these changes touch on the hashing code that @fabriziopandini was looking at for in place propagation of labels...

> Also the fact that any conceptually required field that you want to default needs to be declared optional for client side validation to not complain e.g kubectl, is suboptimal...

I stand corrected :) Thanks folks for digging through these and getting all the information together!