Violet Purcell

Results 27 comments of Violet Purcell

> @vimproved , could you help to address the action issue? Yes, sorry. I've been meaning to look at this for a while now, since I think this PR is...

Updated this PR with a different method of fixing that should be more correct.

Just ran into this myself on linux. This seems to be because it's linking against the static `liblld*` libraries without also checking their dependencies and linking against them (in this...

> so it wants some symbols from static libraries but there are none of them in msys2 libraries? The static LLD libraries use symbols from zlib/zstd, but since zig's build...

> have you tried cmake options: > > ``` > -DZIG_STATIC_ZLIB=ON > -DZIG_STATIC_ZSTD=ON > ``` For distro packaging purposes, I need to link these dynamically.

> Well, that's for users to decide. It's also for users to decide whether they want their system to work properly :). Just because you can use various dubious optimizations...

@falkTX I modified this PR to add a clang CI, and also to automatically detect compiler based on `--version` output.

I've fixed this PR in my own fork in this commit: https://github.com/vimproved/sway/commit/49590198febe073528677c80f2b33ec74ead1c75. It seems like tearing_page_flip needs to be updated every frame, and putting it behind `if (output->gamma_lut_changed || output->tearing_state_changed)`...

Yeah, from my experience testing LLVM 16 in Gentoo --no-undefined-version breaks too many packages. In an ideal world it would be hard error but it's very common currently.

> My latest changes already included the suggestion from @vimproved (thanks!). No problem, thank you for making this PR in the first place! I use the live version of sway...