Phosra comments

Results 39 comments of


                                            Phosra

perf(ops): Monomorphic sync op calls

If it makes it easier to get a first iteration done here, IMO it's reasonable to just do a swift inlining pass that ignores eluding `unwrapOpResult`.

fix(ext/timers): create primordial `eval`

> could you add a test? Sure! I'm trying to write a test case that has a string which simply resolves a `globalPromise: Deferred` variable, but I'm not sure how...

fix(ext/timers): create primordial `eval`

@ry May you review this again?

Incorrect type checking of objects throughout JS codebase

> In fact, the `transfer` field is typed as `sequence` in WebIDL, and the actual type checking happens as part of the structured clone algorithm, not on the WebIDL layer....

feat(ext/ffi): structs by value

Can tests be added for passing structs by value?

experiment(ext/ffi): Replace pointer integers with `v8::External` objects

I'm not sure whether anyone else is supportive of the idea, but considering the amount of repetition in each `op_ffi_read_*`, maybe it should be a macro?

Feature (ext/ffi): Support non-uniform function pointer sizes

With an assertion in place for their sizes, shouldn't the appropriate types be intentionally preferred, as compilation would fail if they differ anyways? I.e. use the correct Rust `fn()` and...

Unobservable vec, and arrays writes always always emit for size >= 3

Is there any way that LLVM could be informed `x.len()

Unobservable vec, and arrays writes always always emit for size >= 3

> For the case of `[T; N]`, from #98121 it seems that emitting `lifetime.end` is not viable. > > A more viable option would be to add an attribute to...

Unobservable vec, and arrays writes always always emit for size >= 3

@rustbot label A-LLVM