Vik R

Results 12 comments of Vik R

> You might need to make a PR for babel-plugin-add-module-exports as well, since it is a devDependency, and also seems to use Babel 6 `babel-plugin-add-module-exports` is actually not good to...

@ljharb Sure that’s fine. Just to note though, babel’s plugins now expose `.default` when using `require`.

This makes more sense to me, but I've often heard bad things about submodules. I say let's try it out and see how it goes.

@Daniel15 For Netlify, [the `YARN_VERSION` environment variable has to be set](https://www.netlify.com/blog/2016/11/01/yarn-support-on-netlify/) or it [defaults to `1.3.2`](https://github.com/netlify/build-image/blob/master/run-build.sh#L23). It can be set either on Netlify's site, or through [`netlify.toml`](https://github.com/electron-react-boilerplate/site/blob/master/netlify.toml#L6). I'm not sure...

[`redux` has separate entry points for compatible code](https://github.com/reduxjs/redux/blob/master/package.json#L28). As of v5, this package is being built strictly toward browsers, which means people can't use/test it with node. `@babel/cli` should be...

@benmosher Could you review this when you have a chance?

@ljharb was thinking the same thing, yeah I'll make a version using an option

Closing in favor of #1217

@benmosher There may be some who are using `require.resolve` on files generated at build time (instead of `path.join`/`path.resolve`).

- Try `require(...).default` instead of `require(...)`. - `export default` can't be nested, but can come after setting a variable via `let`.