Vihang Mehta

Results 30 comments of Vihang Mehta

Fixed. See https://github.com/crypto-browserify/diffie-hellman/pull/21

I am also using broadway player and was very confused why my 640x360 video was rendering as 640x368 with a black bar at the bottom. I too parsed the SPS...

Looks like `H264SwDecInfo` has the cropping info but the `broadwayOnPictureDecoded` call uses `decInfo.picWidth, decInfo.picHeight` for the width and height params instead of cropping them. I guess one could either adjust...

We now mirror our images to quay.io among other registries. See https://quay.io/organization/pixie We will work on making it easier to deploy pixie with custom registries but the mirroring is done.

@KimiNewt can we get a new release with this included so folks can upgrade pyshark and close out CVE-2022-42969?

See #1723 If you are using gazelle and stackb/rules_proto, the upgrade to gazelle 0.35.0 and rules_proto v3 need to be done in lock step.

I think it's okay to skip linting for autogenerated files. Might be worth adding them to the exclusion list and calling this done.

I think if you reduce the tab/spaces in the returns for `gen_method_enum_select_case`, `gen_method_enum_declr` etc to the expected output, the generated code is probably mostly formatted as expected. There's a lot...

Given that you have spent a bunch of time here, I trust your judgement. If you think running `clang-format` as part of the generation isn't too much trouble, that approach...