Viktor Gal

Results 84 comments of Viktor Gal

Not strictly related, but there's a performance regression with the whole `WLibrarySidebar` & `SidebarModel`: when using mouse to scroll around in the `WLibrarySidebar` for some reason even for a smallest...

> Between which versions? Is it related to https://bugs.launchpad.net/mixxx/+bug/1905124 i'm testing based off `main` branch. and yeah probably the bug i was mentioning above is actually related, because currently any...

i'm guessing based on the CI error, that you dont want to explicitly require `std::filesystem` feature out of C++17 standard... or? in case not then i'll revert those changes... in...

> > i'm guessing based on the CI error, that you dont want to explicitly require `std::filesystem` feature out of C++17 standard... or? in case not then i'll revert those...

> By the way, can you please sign https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ > and comment here when done? > This allows to include your patch in Mixxx. > Thank you. 🐐 it's GPLv2,...

ok after spending way too much time in order to fix all the requested changes (using signals/slots, adding a mutex), the whole thing blew up. namely spin ball and blocked...

namely the problem is that `FolderTreeModel::hasChildren` *can* block, either because of a mutex or because of IO... and this should never happen as this is actually used by the TreeView...

@uklotzde just for the reference based on your and [this suggestion](https://stackoverflow.com/q/1144240) patching the following: ``` auto listWorker = [=]() mutable -> void { // we assume that the path refers...

> @vigsterkr have you tried forcing a queued connection ? ``` connect(this, &BrowseFeature::scanDir, &m_childModel, &FolderTreeModel::onNewChildren, Qt::QueuedConnection); ``` this is a queued connection, or? in case yes, then i've tried it...

> I think you should create a real background thread that does the io querying and emitting the results. I did something similar in: > #3406 to populate the infobar...