Victor Sanni

Results 77 comments of Victor Sanni

On Android, not including the `TargetApi` annotation to the `getManifestNames` method in `PermissionUtils.java` causes StrictMode errors: https://developer.android.com/reference/android/os/StrictMode Same with the implicit fallthrough. I have reverted the iOS import changes and...

Hi @LowLevelSubmarine! Are you still planning to add tests and keep working on this PR?

I have been unable to reproduce the bug using [this code sample](https://github.com/flutter/flutter/issues/24505#issuecomment-771714414) (or at least, not been able to notice the shakiness). This is what I have: ![issue](https://github.com/flutter/flutter/assets/77553258/0230cec0-a4b8-4b4c-a58b-e3b1f624e254) Is anyone...

On second look I have been able to reproduce the bug by slowing down the animation duration. This is what is currently happening: ![originalprescaling-ezgif com-video-to-gif-converter](https://github.com/flutter/flutter/assets/77553258/187d9b77-f583-4038-be7a-c5e3d747e65c) Using the scaling workaround from...

> If anyone would like to fix this, it should be relatively easy these days (assuming I'm right about the cause), by using `FontVariation.opticalSize`. Set an optical size on the...

@dylanalizon Does https://github.com/flutter/flutter/issues/119071 fix this issue?

Hi @pento! I'm having difficulty reproducing this bug. Is this still an issue?

Hi @dy0gu, thanks for reaching out. The framework requires tests to prevent your changes from being regressed. Someone could come along in the future and revert these changes, unless a...

> Can you share the code snippet that creates the video above? I am curious where the red color is coming from in the material one. Is this red color...

> > code snippet > > Thanks for the code! Do you think the adaptive one should be red on iOS? Since it is given the same `fillColor: WidgetStateProperty.resolveWith(getColor)`, or...