Adam Zalcman
Adam Zalcman
I think it would make sense for `with_tags` to check the type and raise an exception with informative error message to avoid this in future.
We could also special-case the `type` type: ```python if isinstance(tag, type): tag = tag() ``` (This will certainly upset mypy. There is a longer better way of writing this. This...
This looks like a requirements conflict. On one hand, from the abstract perspective X and its inverse are identical. On the other, they may be implemented differently on the hardware....
@maffoo I don't think treating X and X**-1 qualifies as eliding information because the exponent is periodic. X and X**-1 really are the same gate. It is true that a...
Fair enough. I see how not having to use tags for this makes things easier from the practical standpoint. In any case, we should probably have one consistent approach to...
Regarding rendering, in the unicode mode we could render X inverse as X† which is merely two characters long instead of five in X**-1.
@ncrubin Given @maffoo's explanation, can we close this or is there something else to do here?
Oh, I think I added triage/discuss by accident (probably missed that the issue already had a triage/* label).
Hey, @c-poole! Are you working on this? I'd like to fix #1179 before its birthday and it seems like your suggested approach addresses both issues. I can implement it, unless...
Thank you for checking einsum performance on sparse vs dense matrices! Your result appears to confirm my concerns [here](https://github.com/quantumlib/Cirq/pull/5902#pullrequestreview-1134917469).