Oleg Guba
Oleg Guba
> I have a general comment/observation. Why can't we achieve this with WARM and MIN IP targets? Understand we want to avoid unnecessary assign/detach IP calls in a high churn...
@jayanthvn @achevuru what do you think?
Sorry for the quite long delay. > Reg the environment variable, yes it would be good to have. If environment variable is "not configured" or "0" then we can fall...
Simple optimization for ec2 request count would be to implement WARM_IP_COUNT_LOW/WARM_IP_COUNT_HIGH and trigger release/allocation only once we hit any of these limits. I can work on PR to account addresses...
https://github.com/aws/amazon-vpc-cni-k8s/pull/1703 turned out to be quite huge and not readable, splitting the change into multiple PRs. Published https://github.com/aws/amazon-vpc-cni-k8s/pull/1704 as a first step for implementing delayed cleanup.
@jayanthvn I'm seeing "First-time contributors need a maintainer to approve running workflows." message on https://github.com/aws/amazon-vpc-cni-k8s/pull/1704, would it be possible to approve workflow?
@jayanthvn could you please assist with PR review? There are no updates for more than a week :-(
https://github.com/aws/amazon-vpc-cni-k8s/pull/1703 implements the delayed release logic. I'm not quite happy with the test coverage, though adding unit tests around ipamd might require some additional refactoring, would appreciate any suggestions.
@jayanthvn could you please assist with reviewing changes in PR?
@jayanthvn could you please take one more look at the PR? Thank you!