vemoo
vemoo
I think this is the same as #3720 I wrote the results of some investigations there: https://github.com/pnpm/pnpm/issues/3720#issuecomment-978125390, but I don't know if they are still relevant on pnpm v7.
Yes, I can try to implement this. For v4 at least for inotify shouldn't be too hard since it's already using `WalkDir` internally. For windows and mac I'll have to...
I've started working on the feature for v4, and I have a few questions. - I think ideally the filtering should in `RecursiveMode` something like: ```rust pub enum RecursiveMode {...
> Can you explain what you mean by > > > Also to make the configuration more complete I was thinking of exposing a `Fn(&Path)->WalkDir` So that the user could...
I think I found a way to do it [here](https://github.com/vemoo/notify/blob/watch-filter/src/recursion.rs). I've created an abstraction for the watcher implementation: [`WatcherInternal`](https://github.com/vemoo/notify/blob/ffc3c8f8217515eab2b59c7b1bec0357f557c984/src/recursion.rs#L60-L66) and that way I can implement the recursive filtering and keep...
I have it mostly working for `inotify` (https://github.com/vemoo/notify/tree/watch-filter). There's 1 test (`watch_recursive_move_out`) that fails always and some other that fails ocasionally. I'll investigate. I have yet to add tests for...
I'm slowly making progress. The test that was failing was a timing issue, I fixed it here: https://github.com/vemoo/notify/commit/51d80bc1ed7f1a7ec88f8b50b009f832fa4f938d I ended up implementing filtering for files also, because it wasn't that...
It seem this approach doesn't work for windows. Because windows doesn't allow to delete the watched directory neither renaming the parent directory, and in this approach we create a non...
This has been fixed on [v8.6.3](https://github.com/pnpm/pnpm/releases/tag/v8.6.3), I'm not sure it has been fixed on v7
Would it make sense to only treat imports like node when `platform` is set to `"node"`? That way this issue could be avoided without having to remove `"type": "module"`.