Vegard Løkken
Vegard Løkken
My understanding is that `HttpClient`s created by `IHttpClientFactory` don't need to be disposed explicitly: > Disposal of the client isn't required. Disposal cancels outgoing requests and guarantees the given HttpClient...
Yes, if Refit did `new HttpClient()`, I totally agree it would need explicit disposal, but Refit uses `IHttpClientFactory` and as such is _not_ required to dispose the client. Please correct...
@Timovzl Sure, I get your point - it wouldn't hurt. But still, it's not a bug per se in the current implementation. @mikhail-barg That is something else. The Refit client...
@derekm While updating the docs, it wouldn't hurt with a big fat warning in the "Using HttpClientFactory" section about injecting Refit clients (or any typed HttpClient for that matter) into...
I guess it depends on how the `ITokenProvider` is implemented. If you're using `IHttpContextAccessor` to get the current request's token, your message handler approach should be fine, e.g: ```csharp httpContextAccessor.HttpContext?.Request.Headers[HeaderNames.Authorization]...
> Can't you already handle this by using eslint `overrides`? Some use-cases can be solved with `overrides`, but sadly not all. If you have multiple zones for the same `target`...
For our use-case specifically, we managed to find a way using `overrides` in the end (though not as clean as I hoped), so this issue is not a blocker for...
> also can't `target` be combined with `except` already? No, `except` applies only to `from` as the documentation states: > `except` may be defined for a zone, allowing exception paths...
Yeah, the example is not 100%. `MockedService` is actually registered as a singleton in an IoC container and used for DI throughout an ASP.NET application so I need to mutate...