Vlastimil Eliáš comments

Results 29 comments of


                                            Vlastimil Eliáš

#92 validation by server side plugin

OK, looks like solution for tests is to wrap whole `describe` part into function, and then call it twice from two other `describe` parts for each type of server side...

#92 validation by server side plugin

@confuser friendly reminder :-D I'd like to agree how to proceed next.

#92 validation by server side plugin

@confuser testsuite updated to reuse tests for both implementations, best example is `/test/argument.test.js`. Only part of tests covering implemented features is running for the new server validator implementation for now....

#92 validation by server side plugin

@confuser looks like server plugin implementation is finished, any comments welcome

#92 validation by server side plugin

I believe it is ready to review 😀

#92 validation by server side plugin

Sorry, I noticed improvement in Envelop plugin and README, now it is really done :-)

#92 validation by server side plugin

@confuser any progress ;-)

Feature Request: run as server validation rules instead of wrapping schema types

This approach allows to keep Schema as is, without changing types to custom scalars. So in schema there will be common String or Int, but query validation will be applied...

Feature Request: run as server validation rules instead of wrapping schema types

And this might also solve Apollo Federation issue #41 as federation runs in Apollo Server so I believe `validationRules` can be used there (not tested from me).

Feature Request: run as server validation rules instead of wrapping schema types

Good point, but looks like there is a workaround, by providing variables during the rule construction. For example see how [graphql-query-complexity plugin](https://github.com/slicknode/graphql-query-complexity#usage-with-express-graphql) solves it. But this probably limits usage of...