Igor Kushnir
Igor Kushnir
There are no error messages from *udisks* in _journalctl_. #### Messages unique to the disk that is put to sleep 1. These messages appear on resume from hibernation, but before...
Not sure if the `timsort` namespace is a good idea. The namespace name clash is relatively benign. An entity other than namespace could be named `timsort` and *that* conflict would...
There is also a crash on exit from YACReader Library after removing a comic or a folder. I have already fixed it and will create a pull request soon.
> How did you tested it? Moving quickly between folders in YACReaderLibrary, or fast opening next/previous comic in YACReader while the flow is shown (using CTRL + Left/Right) can be...
This pull request does not touch the workers. The changes here seem to be pretty safe to me. The removed `if (images[item].index == item)` check in `YACReaderFlowGL::replace()` looks like a...
> I have some memories about the worker loading an image from the previous content while the flow is repopulated, causing a wrong image being displayed in the flow, because...
I have implemented many more somewhat dependent fixes on top of this branch: https://github.com/vedgy/yacreader/commits/navigation-reloading-drag-fixes. I'll create a separate pull request after this one is merged.
I've cleaned up `Render` code somewhat in https://github.com/vedgy/yacreader/commits/clean-up-render based on this branch. I'll create a separate pull request after this one is merged to avoid resolving merge conflicts repeatedly.
Mac and Windows builds have failed because the `ExtractDelegate` class in [*compressed_archive/extract_delegate.h*](https://github.com/YACReader/yacreader/blob/3a9bec55f8f882cf5acd1fb8ccb6eafbd7bd022d/compressed_archive/extract_delegate.h) lacks `virtual bool isCancelled() = 0;` and so can be overriden only if *unarr* backend is used. Removing...
> And this is my problem with the provided PR - it enforces the antipattern and the code cleanup makes it look like this is how it is supposed to...