vdepizzol

Results 18 comments of vdepizzol

Most, if not all, of these issues are fixed by https://github.com/primer/css/pull/1979.

@simurai I'd replace Helvetica with "Helvetica Neue", and try to be a little more specific with the available OS options before fallbacking to Arial/Liberation Sans. [Reading a little bit](https://fontsarena.com/blog/operating-systems-default-sans-serif-fonts/) through...

I'm moving this back to a draft to update the proposal with full support for accessibility and better naming. Thank you @alliethu and @ashygee 🎉 !

@ashygee: > after our conversation we had discussed that the full version of the Banner (Flash) component would be what we currently style as `.flash-banner`, see screenshot below. I did...

@langermank @simurai @ashygee opening this again for review! I'm not addressing WAI-ARIA requirements at this time, I believe a full audit and decisions can happen once the PVC component is...

@mperrotti The use of `NavigationList` should support sub-groups. @siddharthkp has been experimenting with the use of `ActionList` -- and I have just summarized some of the ideas in this issue:...

@langermank and I are finalizing the last bits of this documentation as we wrap its API design and implementation. I'll mark it as **Ready for review** again once this is...

@simurai looking great! quick _quick_ comments: - I think icon buttons have a more subtler color other than `fg.default`? - We probably need to confirm the padding around the icons...

> I'm going to run this idea of having a tooltip by default at tomorrow's Primer Patterns working group session to get any feedback or concerns before we run with...

@siddharthkp love where this is going! Option 3 makes a lot of sense. Just a comment on shortcut placement. I believe we'd still benefit from a specific slot for shortcuts...