Varnson Fan

Results 11 comments of Varnson Fan

@spencergibb Do you have a plan to merge this PR?

There are ci errors, and I think the sleep is too short in the remove test. But I do not know how to trigger the ci again.

@spencergibb The ci error is "This job has been blocked because resource-class:large is not available on your plan. Please upgrade to continue building.", not compile error or test error.

I had added waitTime and index in getServers() of ConsulServerList.java in my company. This changed getHealthServices() to be a blocking query. I also want to add cached parameter in it....

Consul supports multiple data centers to share data, but is different with eureka. So I don't think it's a good idea to use consul in the eureka way. Consul has...

@ezraroi Yes, consul support service discovery via multiple data center. And consul has a query interface to query services between data centers. https://www.consul.io/api/query.html So I think there is no need...

In Finchley, this method is useless, I don't know why catalogservice was called frequently.

@lornasong Sorry for My comment is not clear enough. the condition is (if check.Status == status && check.Output == output ) At your case ,status is critical, but output may...

@lornasong About anti-flapping feature, I hadn't read the consul source very carefully, but I found the source like this: https://github.com/hashicorp/consul/blob/master/agent/checks/check.go#L828 This source is very like my source for this fix....