Andrew Varner
Andrew Varner
Should clarify that the reproducing test is https://github.com/varnerac/Ace/blob/large_response_reproducer/test/ace/http2_test.exs#L277-L292 It relies on a change in the simple app here: https://github.com/varnerac/Ace/blob/large_response_reproducer/test/support.exs#L110
I did not
@CharlesOkwuagwu I’ll try to look this evening. In the meantime, you could add the test from https://github.com/CrowdHailer/Ace/pull/151 to your PR as a test.
Also here: https://github.com/CrowdHailer/Ace/blob/master/lib/ace/http/service.ex#L272
Ok, I understand what happened here. [Older versions of Elixir](https://hexdocs.pm/elixir/1.6.4/Supervisor.html#start_child/2) allowed the last argument to be a list of terms. That's no longer the case. This breaks dialyzer on recent...
I’ll look today. FWIW, the h2spec test results show up in my CircleCI setup.
I changed the Travis config to only run h2spec tests in the latest Erlang/Elixir entry in the matrix. Seems to have fixed the issue.
Any thoughts on this?
Will do
I’ll take a look in next few days. Thanks.