Vincent Vanackere
Vincent Vanackere
Quick proposal to solve https://github.com/dop251/goja/issues/426
I did a quick proof-of-concept implementation in the linked pull-request. This would be enough for my need at least (even if I understand that this does not solve all related...
Hi @dop251 , gentle ping to have your opinion on this since a mechanism like this would really help a lot in our codebase, thanks !
Yes, as long as the behaviour is unchanged this looks like a worthwhile change. Thanks ! Le jeu. 16 mai 2019 à 22:33, Daniel Theophanes a écrit : > Would...
Hi @kardianos , do you still intend to implement this ?
Hi, Our handling of non-ascii passwords is indeed not ideal. The bug might be either in repeatMatch or in the way we compute the scoring... Both parts should probably be...
You're right... but this is not really a copy-paste error: the reference dropbox/zxcvbn coffeescript code uses the same array for both layout. I also noticed this during development of this...
Indeed we could switch to a new reference client-side implementation since the dropbox/zxcvbn library looks unmaintained / not very active... Do you have any suggestion ?
Looking at it again a few month later: yes, it seems indeed like a good idea to switch to follow zxcvbn-ts instead. However I don't have any time to work...
@buger : I was in the process of writing the exact same pull request when I noticed this was already there... Any chance to have this merged ?