Valithor Obsidion

There wasn't a way to get a part's $fillable array from outside of the class, which can make it tricky to dynamically create an object in certain use-cases. This resolve...

Unavailable servers prevent setupChunking()

2

https://github.com/discord-php/DiscordPHP/blob/cf79ca6ada74102b50ade8f84d99db028d585505/src/Discord/Discord.php#L459 setupChunking never gets called if something goes wrong and a server that is expected to load never loads. Removing this if statement or calling setupChunking() after a set amount...

fget truncate alternative?

7

I'm hoping to port some of my existing code over to ReactPHP Filesystem to make reading lines from a file and truncating it afterwards asynchronous so that my main loop...

Replace is_resource usage with !== false

1

See https://wiki.php.net/rfc/resource_to_object_conversion

Promises v3 Checklist

4

Per https://github.com/reactphp/promise/releases/tag/v3.0.0 Irrelevant: - [x] Existing instances of FulfilledPromise and RejectedPromise classes must be updated to use resolve() and reject() functions instead - [x] Existing instances of LazyPromise should be...

- [ ] A massive part of the library currently relies on `$promise->done()`. This will be the largest part of the promises v3 changes and will break a lot of...

[$deferred->reject();](https://github.com/discord-php/DiscordPHP/blob/9fab769aa47a57052f6fa0309bcede6abe81e0ca/src/Discord/functions.php#L316) was the only instance I could immediately find

Minor code cleanup

1

Made some readability changes and moved the resolved/reject handling code into functions outside of the Deferred constructor, and used === instead of ==

Godot 4 support

1

Are there any plans to update this to work with Godot 4?