Ahmed Hamdy
Ahmed Hamdy
@MartijnVisser @zentol could you please review?
@paulh86 Blocked on review from the community, will reach out on dev slack channel for a reviewer
@rjbaucells Hello, It is pending approval from @MartijnVisser
Hi @Samrat002 Great Work! thanks alot, the PR is in a good state IMO. I would add a test for the Factory class as well where we assert it creates...
@dannycranmer Thanks for the feedback, I have addressed your comments. Alternatively I decided to follow an approach similar to `RowDataToAttributeValueConverter` to avoid using reflection. PTAL
@hlteoh37 Thanks, for the feedback, the reason we took this approach is that We are trying to couple it as much as possible with Flink's TypeInfo Class, Using `AttributeConverterProvider` is...
@hlteoh37 Do you have other comments or could we merge this PR?
Thanks @19priyadhingra for addressing the comments, could we fix the spotless violations as mentioned above?
There are some style violations, Could you run `mvn spotless:apply` ahead of the PR please?
Thanks @robg-eb , @hlteoh37 could you please take a look