Vadim Dvorovenko

Results 9 comments of Vadim Dvorovenko

One more code snippet for tests, where last case ends with comment ```php

@julienfalque , please add to your unit tests example from https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/6491#issuecomment-1204869741 to check it will be fixed too

@julienfalque , thanks. But it seems your test is covering only cases with single line comments. Are you sure that you test for ```php case_or_default: // Nothing to do ```...

> I tested with your exact sample and the tests pass. Great! Thanks again

Currently i use Laravel container to Mock Serivce In application ``` $options = array( AbstractSoapClientBase::WSDL_URL => 'https://xxxx?wsdl', AbstractSoapClientBase::WSDL_CLASSMAP => ClassMap::get(), ); $service = app()->make(new Service($options)); $service->setSoapHeaderHeader($header); if ($send->sendToESP(new ServiceRequest()) !==...

One of improvement that i currently can see, is to add config option for class name, and pass this option to getSoapClientClassName in initSoapClient, because currently there is no other...

@browner12 , referer is header, and it can be easily manipulated with middleware. Maybe it's better to create some middleware SanitizeHeaders, wich will remove referrer header at all? If you...

@artengin , does you implementation have any profits over one-liner from https://www.php.net/manual/ru/ref.mbstring.php#121807 ? You have condition for negative offset, but your tests does not cover it. You may use negative...

@DanielEScherzer , @Crell Please take a look at https://github.com/php/doc-en/pull/5083 , it is relevant to pipe operator too