v-homsi

Results 7 comments of v-homsi

@facs95 @fedekunze @danburck After digging deep into go-ethereum code and investigating the different alternatives, here are the different approaches to support metrics on the EVM rpc: ## Approach 1: go-ethereum...

> > Need to add --metrics to our start command and I don't think ethermint could support a config file option (app.toml) for this > > @v-homsi Why can't we...

> @v-homsi thanks! Let's add the new files into `client/`, `server/`, and the other existing folders. We also need to add a new API breaking change entry in the Changelog....

Converting this PR to draft PR again. I came across https://github.com/ledgerwatch/erigon and I would like to investigate potentially replacing `go-ethereum` with `erigon` instead of migrating the code as `erigon` has...

> > > > Need to add --metrics to our start command and I don't think ethermint could support a config file option (app.toml) for this > > > >...

After discussions with @facs95 regarding this PR, he suggested to go with [approach 1](https://github.com/evmos/ethermint/pull/1303#issuecomment-1237285631) and try to upstream changes to go-ethereum suitable for our use cases instead of migrating the...