Tingqian Li

Results 16 comments of Tingqian Li

@maxnick Can you please help to review this PR?

@dmitry-gorokhov @maxnick I removed the confusing initialization of `internalBlobDesc` in constructor since we are using another overload of `prepareMemory`, PR is updated, please review again, thank!

@dmitry-gorokhov sure, will try to add one

@dmitry-gorokhov @maxnick I try to add a test case dynamically switch between batch sizes 1 and 20, to trigger the WA branch `if (SL != 1 || B < optimalBatchSize)`...

@maxnick I changed some data range, CPU tests are good now, but GNA test failed, I don't have GNA environment so maybe I can only change the data range specifically...

@maxnick I reverted some change and now only dynamic batch switching test will use special initial W/R/B value and abs_threshold, these special values & threshold are tuned so that the...

@maxnick Hi, Can you please review this PR?

@dmitry-gorokhov @maxnick we will have difficulty when CPU_DENORMALS_OPTIMIZATION wasn't set and internal flag `denormalsOptMode` will be `DenormalsOptMode::DO_Keep` and we have no way to tell whether DAZ is set other than...

@maxnick I find that it's difficult to get graph's config inside constructor of Input node(for checking CPU_DENORMALS_OPTIMIZATION flag), actually it's hard to add any new input parameter into constructor of...

@maxnick I changed the implementation according to config, please review again, Thx!