Martin Urbanec comments

Results 9 comments of


                                            Martin Urbanec

Test, improve and document the dev data population script

Hello, that's me again :-). What is "improve"? Tasks in GCI need to have clear criteria, so students know what is expected from them and what is and is not...

Test, improve and document the dev data population script

Ping? :-)

Test, improve and document the dev data population script

Perfect for me :)

Test, improve and document the dev data population script

Thanks! A question, which submission should the students submit into the repo?

[AccountEligibility] display of edits per wiki/global number of edits is confusing

Hello, I admit this confused me for quite a while as well. The suggestion you had at Meta, to say "has 40 edits on this wiki, 290 total so far"...

Twig intl-extra depends on intl PHP extension, but does not declare such dependency

> > although that package is deprecated > > Where did you see that this package is deprecated ? I was looking at https://symfony.com/doc/3.x/components/polyfill_intl_icu.html. However, on second look, it is...

Twig intl-extra depends on intl PHP extension, but does not declare such dependency

> > composer.json supports declaring dependencies on PHP extensions as well (by depending on ext-intl). I propose we add that dependency, which would make composer.json complain directly when installing. >...

Twig intl-extra depends on intl PHP extension, but does not declare such dependency

> Well, that doesn't really work in this case. Take eg Drupal, which could require this package and decide to attach the polyfill to make installing it easier. If we'd...

Add ext-intl requirement to composer.json

I just realised I probably should've sent this to https://github.com/twigphp/Twig/issues/4702 instead. Done. Happy to make further changes if needed.