Nate Goldman

Results 89 comments of Nate Goldman

I think detecting line endings would be better than creating a very unusual custom line endings option. PRs welcome!

I don't know of anything in any markdown specs called markdown comments, are you talking about HTML comments? Like ``? If you can provide an example of the text that...

If you can provide an example of the text that that's causing an issue for you that would be very helpful.

Thank you! That makes the issue much clearer. This parser currently has no support for ignoring single or multiline HTML comments -- ignoring single line comments would be fairly simple,...

Makes sense to me! ~I can approve and merge here but I'm not a collaborator on npm so I'm unable to publish this fix.~ ~I'll hold off on approving until...

Hey @jakiestfu I'm going to fork this project and publish a new version with this fix under a scoped namespace (`@ungoldman/himawari`) just to be able to work with this module...

@jakiestfu what color correction techniques are you using above?

You're not going to be able to get quite the same result as above working with a single full disk image but you could use @celoyd's [color tweaks](https://gist.github.com/celoyd/b92d0de6fae1f18791ef#color-tweaks) suggestions from...

Thanks @celoyd for taking time to get into the details! :grin: :ok_hand: :100: