Umut Uzgur

Results 16 comments of Umut Uzgur

We actually implemented this at Checkly. The problem is that you gotta create a intervalled scraper to use remote_write correctly to avoid the timestamp out of order errors. I can...

Hey @lehni, I tested the latest release and I can verify that this is still not fixed. I think we should reopen the issue

I think this is the piece of code that is causing the issue as it is treating update and patch the same https://github.com/Vincit/objection.js/blob/260b284a1cbfb044991894c5a3cf3dedc8ce7267/lib/queryBuilder/graph/patch/GraphPatchAction.js#L36 ```js const allProps = union(changedProps, unchangedProps); const...

This should be something like this IMO ```js const allProps = union(changedProps, unchangedProps); let compareSet if (shouldPatch) { compareSet = changedProps } else if (shouldUpdate) { compareSet = allProps }...

I found a way by hacking the `$set` method and manipulating the `$$omitFromDatabaseJson` field. It is basically the change detection code in GraphPatchAction baked into the $set function ```js $set...

@lehni my example was buggy. I see why you couldn't repro it. I updated the example in the issue description. I can also create a new issue if you want

> This doesn't seem to fix the reproduction though. Did it work for you @umutuzgur? > > > This should be something like this IMO > > ```js > >...

We can also follow the `$set` fix if we want to. We will probably follow that path internally

Gotcha. To be honest, this has been broken since the upgrade to version 2, so a while, and probably some people already got used to this new behaviour. I don't...

@lehni awesome, this great news! I can give it a go in our app as well this week